Fixed buildlogs #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to work with go-systemd to see if we can abstract the syscall.CloseOnExec which is not supported on windows.
It currently is impossible to use two healthz handlers on different ports in the same process. This removes the global variables in favor of requiring the consumer to specify all health checks up front.
Reflects an upstream change to weed out inconsistency in the cluster.
This was referenced Mar 20, 2015
Closed
smarterclayton
force-pushed
the
rebase_kube
branch
3 times, most recently
from
3a79acb to
c70d3bc
Compare
Owner
|
Thanks, cherry picked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix your problem from here regarding build logs. The problem is that upstream adds currently
http://by default in the redirector (see here) but they didn't (see here)It's flaky IMHO, they should allow you to set the Scheme for yourself, don't you think?